Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global sort documents update #16605

Merged
merged 12 commits into from
Mar 26, 2024
Merged

Global sort documents update #16605

merged 12 commits into from
Mar 26, 2024

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Feb 27, 2024 •
edited
Loading

Reverts #16202

translated from: pingcap/docs-cn#16665

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2024
@qiancai qiancai added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Feb 27, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Feb 27, 2024
@qiancai qiancai added missing-translation-status This PR does not have translation status info. v8.0 labels Feb 27, 2024
@qiancai qiancai self-assigned this Feb 27, 2024
qiancai
qiancai commented Mar 1, 2024
View reviewed changes
sql-statements/sql-statement-import-into.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
tidb-global-sort.md Outdated Show resolved Hide resolved
@qiancai qiancai removed the missing-translation-status This PR does not have translation status info. label Mar 4, 2024
lilin90
lilin90 reviewed Mar 7, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
tidb-global-sort.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Mar 8, 2024
View reviewed changes
tidb-global-sort.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 8, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-08 03:17:13.815810566 +0000 UTC m=+396260.838056955: ☑️ agreed by lilin90.

qiancai
qiancai commented Mar 20, 2024
View reviewed changes
tidb-global-sort.md Outdated Show resolved Hide resolved
Benjamin2037
Benjamin2037 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 20, 2024

@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Frank945946
Frank945946 approved these changes Mar 21, 2024
View reviewed changes
sql-statements/sql-statement-import-into.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
tidb-global-sort.md Outdated Show resolved Hide resolved
tidb-global-sort.md Outdated
@@ -20,7 +21,7 @@ summary: Learn the use cases, limitations, usage, and implementation principles

The TiDB Global Sort feature enhances the stability and efficiency of data import and DDL (Data Definition Language) operations. It serves as a general operator in the [TiDB Distributed eXecution Framework (DXF)](/tidb-distributed-execution-framework.md), providing a global sort service on cloud.

The Global Sort feature currently only supports using Amazon S3 as cloud storage. In future releases, it will be extended to support multiple shared storage interfaces, such as POSIX, enabling seamless integration with different storage systems. This flexibility enables efficient and adaptable data sorting for various use cases.
Currently, the Global Sort feature supports using Amazon S3 as cloud storage. In future releases, it will be extended to support multiple shared storage interfaces, such as POSIX, enabling seamless integration with different storage systems. This flexibility enables efficient and adaptable data sorting for various use cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future releases, it will be extended to support multiple shared storage interfaces, such as POSIX, enabling seamless integration with different storage systems. This flexibility enables efficient and adaptable data sorting for various use cases.
@Benjamin2037 这类期货建议就先不写吧，你觉得呢。

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 21, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilin90
Copy link
Member

lilin90 commented Mar 21, 2024

ad60a8b LGTM

qiancai
qiancai commented Mar 21, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Mar 21, 2024
View reviewed changes
tidb-global-sort.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Mar 21, 2024
View reviewed changes
tidb-global-sort.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Mar 21, 2024
View reviewed changes
tidb-global-sort.md Outdated Show resolved Hide resolved
@lilin90
Copy link
Member

lilin90 commented Mar 21, 2024

LGTM

@qiancai
Copy link
Collaborator Author

qiancai commented Mar 21, 2024

/approve

@qiancai qiancai added the lgtm label Mar 21, 2024
@ti-chi-bot ti-chi-bot bot added the approved label Mar 21, 2024
@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2024
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 22, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiancai qiancai added needs-cherry-pick-release-8.0 and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit c05eb6f into master Mar 26, 2024
9 of 10 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #16838.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 26, 2024
Merged
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 26, 2024
@qiancai @ti-chi-bot
Global sort documents update (pingcap#16605)
89d2b74
ti-chi-bot bot pushed a commit that referenced this pull request Mar 26, 2024
@ti-chi-bot
Global sort documents update (#16605) (#16838)
0926467
@Oreoxmt Oreoxmt deleted the revert-16202-revert-15905-global_sort_release-15885 branch June 19, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frank945946 Frank945946 Frank945946 approved these changes

@lilin90 lilin90 lilin90 approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qiancai @lilin90 @ti-chi-bot @Benjamin2037 @Frank945946