Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: add description about deprecating the tidb_disable_txn_auto_retry system variable #16541

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Feb 21, 2024

What is changed, added or deleted? (Required)

Add description about deprecating the tidb_disable_txn_auto_retry system variable

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added for-release This PR relates to a TiDB release but does not have a tracked feature. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.0 labels Feb 21, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2024
@lilin90 lilin90 requested review from cfzjywxk and qiancai February 21, 2024 02:21
Copy link

ti-chi-bot bot commented Feb 21, 2024

@cfzjywxk: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

optimistic-transaction.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 21, 2024
Copy link

ti-chi-bot bot commented Feb 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-21 03:02:25.722174281 +0000 UTC m=+412634.469797390: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <[email protected]>
@lilin90 lilin90 added the lgtm label Feb 23, 2024
@lilin90 lilin90 self-assigned this Feb 28, 2024
@lilin90 lilin90 removed the for-release This PR relates to a TiDB release but does not have a tracked feature. label Feb 28, 2024
@lilin90
Copy link
Member Author

lilin90 commented Mar 19, 2024

/approve

Copy link

ti-chi-bot bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 4a79313 into pingcap:master Mar 19, 2024
8 of 9 checks passed
@lilin90 lilin90 deleted the cfzjywxk-patch-1-16602 branch March 19, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants