Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the introduction to UPPER() and WEIGHT_STRING() #16534

Merged

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Feb 20, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update the introduction of UPPER and WEIGHT_STRING, fix pingcap/docs-cn#15953

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Feb 20, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2024
@lilin90 lilin90 changed the title Update the introduction of UPPER and WEIGHT_STRING Update the introduction of UPPER and WEIGHT_STRING [WIP] Feb 20, 2024
@lilin90 lilin90 changed the title Update the introduction of UPPER and WEIGHT_STRING [WIP] Update the introduction of UPPER() and WEIGHT_STRING() Feb 26, 2024
@lilin90 lilin90 changed the title Update the introduction of UPPER() and WEIGHT_STRING() Update the introduction to UPPER() and WEIGHT_STRING() Feb 26, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2024
@lilin90 lilin90 requested review from yibin87 and qiancai February 26, 2024 08:08
@@ -71,40 +55,38 @@ The `BIN()` function is used to convert the given argument into a string represe
- If the argument is a string that consists of digits and non-digits, the function returns the result according to the consecutive digits at the beginning of the argument. For example, the results for `"123q123"` and `123` are the same.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIN('123q123') will generate warnings like, better mention it:
mysql> show warnings;
+---------+------+----------------------------------------------+
| Level | Code | Message |
+---------+------+----------------------------------------------+
| Warning | 1292 | Truncated incorrect INTEGER value: '123q123' |
+---------+------+----------------------------------------------+
1 row in set (0.00 sec)

Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
@lilin90
Copy link
Member Author

lilin90 commented Feb 27, 2024

All the comments have been resolved. @yibin87 @qiancai PTAL again. Thanks!

Copy link

ti-chi-bot bot commented Feb 27, 2024

@yibin87: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-27 07:13:04.190010108 +0000 UTC m=+946072.937633219: ☑️ agreed by qiancai.

@lilin90 lilin90 added the lgtm label Feb 27, 2024
@lilin90
Copy link
Member Author

lilin90 commented Feb 27, 2024

/approve

Copy link

ti-chi-bot bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9b750c2 into pingcap:master Feb 27, 2024
9 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Feb 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16606.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enrich Documentation: 完善字符串函数 UPPER() 和 WEIGHT_STRING() 的文档说明
4 participants