Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the limitation on plan cache for partitioned tables. #16359

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Removed the limitation on plan cache for partitioned tables. #16359

merged 7 commits into from
Mar 19, 2024

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Jan 29, 2024 •
edited by hfxsd
Loading

Both for prepared statements and non-prepared statements. But only for tidb_partition_prune_mode = dynamic.

What is changed, added or deleted? (Required)

Updated the docs according to the TiDB pr pingcap/tidb#49161.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@mjonss
Removed the limitation on plan cache for partitioned tables.
4956a2b 
Both for prepared statements and non-prepared statements.
But only for tidb_partition_prune_mode = `dynamic`.
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2024
@qiancai qiancai self-assigned this Jan 29, 2024
@qiancai qiancai added the v8.0 label Jan 29, 2024
@qiancai qiancai requested a review from joey-yez January 29, 2024 10:14
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Jan 29, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 29, 2024
@qiancai qiancai assigned hfxsd and unassigned qiancai Feb 1, 2024
@hfxsd hfxsd requested review from hfxsd and Oreoxmt February 1, 2024 03:31
@hfxsd hfxsd mentioned this pull request Feb 2, 2024
Merged
18 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Feb 2, 2024
@hfxsd hfxsd requested a review from songrijie February 2, 2024 07:02
songrijie
songrijie approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@songrijie songrijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 6, 2024

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 19, 2024
Oreoxmt
Oreoxmt approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

partitioned-table.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 28, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-19 04:09:42.481819502 +0000 UTC m=+243871.229442613: ☑️ agreed by hfxsd.
  • 2024-02-28 08:18:17.200114132 +0000 UTC m=+1036385.947737245: ☑️ agreed by Oreoxmt.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2024
hfxsd
hfxsd reviewed Mar 19, 2024
View reviewed changes
optimizer-fix-controls.md Outdated Show resolved Hide resolved
songrijie
songrijie approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@songrijie songrijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 19, 2024

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hfxsd
hfxsd reviewed Mar 19, 2024
View reviewed changes
optimizer-fix-controls.md Outdated Show resolved Hide resolved
@hfxsd
Copy link
Collaborator

hfxsd commented Mar 19, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 55af1af into pingcap:master Mar 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@songrijie songrijie songrijie approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@joey-yez joey-yez Awaiting requested review from joey-yez

Assignees

@hfxsd hfxsd

Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mjonss @hfxsd @songrijie @Oreoxmt @qiancai