Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(tidb-troubleshooting-map): add flow control instruction on top… #16172

Merged
merged 6 commits into from
May 14, 2024

Conversation

hzc989
Copy link
Contributor

@hzc989 hzc989 commented Jan 16, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

update tide-trouble-shooting-map.md, update the tikv server is busy part

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

related Change Request pingcap/docs-cn#8135
I'm participating the 2024-tidb-doc-dash https://github.com/orgs/pingcap/projects/51/views/3

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Jan 16, 2024
Copy link

ti-chi-bot bot commented Jan 16, 2024

Welcome @hzc989!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2024
@qiancai qiancai added 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Jan 18, 2024
@qiancai qiancai self-assigned this Jan 23, 2024
@qiancai
Copy link
Collaborator

qiancai commented Jan 26, 2024

Hi @hzc989, I'm sorry to let you know that, according to the confirmation from @Connor1996 (a developer of TiKV), the issue #8135 is invalid and does not necessitate any documentation updates. Nonetheless, you'll still get the points for creating this PR in the Docs Dash 2024 event, and I sincerely appreciate your effort on resolving this issue.

If it is acceptable to you, could you please close this PR? Thanks.

@qiancai qiancai self-requested a review January 26, 2024 10:34
@Connor1996
Copy link
Member

Hi @hzc989, I'm sorry to let you know that, according to the confirmation from @Connor1996 (a developer of TiKV), the issue #8135 is invalid and does not necessitate any documentation updates. Nonetheless, you'll still get the points for creating this PR in the Docs Dash 2024 event, and I sincerely appreciate your effort on resolving this issue.

If it is acceptable to you, could you please close this PR? Thanks.

Do not bother to close it, the description still needs to be updated for flow control.

@qiancai
Copy link
Collaborator

qiancai commented Feb 21, 2024

Hi @hzc989, would you please update the English PR according to the latest changes in pingcap/docs-cn#16193? Thanks.

this change is refered to the chinese version PR, pingcap/docs-cn#16193
@hzc989
Copy link
Contributor Author

hzc989 commented Mar 7, 2024

Hi @qiancai , updated , plz review.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 8, 2024
@hfxsd hfxsd self-requested a review May 11, 2024 02:30
tidb-troubleshooting-map.md Outdated Show resolved Hide resolved
tidb-troubleshooting-map.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 11, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2024
Copy link

ti-chi-bot bot commented May 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-11 02:53:06.94178251 +0000 UTC m=+1276140.698918082: ☑️ agreed by hfxsd.
  • 2024-05-14 07:26:37.664629209 +0000 UTC m=+1551751.421764783: ☑️ agreed by qiancai.

@qiancai
Copy link
Collaborator

qiancai commented May 14, 2024

/retest

@qiancai qiancai added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.6 labels May 14, 2024
@qiancai
Copy link
Collaborator

qiancai commented May 14, 2024

/approve

Copy link

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 14, 2024
@ti-chi-bot ti-chi-bot bot merged commit a405139 into pingcap:master May 14, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17486.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17487.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #17488.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Development

Successfully merging this pull request may close these issues.

6 participants