add disable public endpoint #16147
Merged
add disable public endpoint #16147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
missing-translation-status
ran-huang
added
translation/no-need
ti-chi-bot
bot
removed
the
missing-translation-status
ran-huang
reviewed
Jan 15, 2024
|
|
||
| 1. Navigate to the [**Clusters**](https://tidbcloud.com/console/clusters) page, and then click the name of your target cluster to go to its overview page. | ||
|
|
||
| 2. Click **Network** in the left navigation bar and click **Disable** in right pane. A confirmation dialog is displayed. |
There was a problem hiding this comment.
Suggested change
| 2. Click **Network** in the left navigation bar and click **Disable** in right pane. A confirmation dialog is displayed. | |
| 2. Click **Network** in the left navigation bar and click **Disable** in the right pane. A confirmation dialog is displayed. |
|
|
||
| 3. Click **Disable** in the confirmation dialog. | ||
|
|
||
| After disabling, the **Public** entry in the **Endpoint Type** drop-down list in the connect pane is disabled. If users are still trying to access the cluster from Public Endpoint, an error will be returned. |
There was a problem hiding this comment.
Suggested change
| After disabling, the **Public** entry in the **Endpoint Type** drop-down list in the connect pane is disabled. If users are still trying to access the cluster from Public Endpoint, an error will be returned. | |
| After disabling the public endpoint, the **Public** entry in the **Endpoint Type** drop-down list in the connect pane is disabled. If a client tries to access the cluster from the public endpoint, an error will be returned. |
|
|
||
| 1. Navigate to the [**Clusters**](https://tidbcloud.com/console/clusters) page, and then click the name of your target cluster to go to its overview page. | ||
|
|
||
| 2. Click **Network** in the left navigation bar and click **Enable** in right pane. |
There was a problem hiding this comment.
Suggested change
| 2. Click **Network** in the left navigation bar and click **Enable** in right pane. | |
| 2. Click **Network** in the left navigation bar and click **Enable** in the right pane. |
ran-huang
reviewed
Jan 16, 2024
ran-huang
reviewed
Jan 16, 2024
Co-authored-by: Grace Cai <[email protected]>
ran-huang
approved these changes
Jan 16, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ran-huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?