Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enrich instructions for string functions INSTR() and LCASE() #16144
Enrich instructions for string functions INSTR() and LCASE() #16144
Changes from 9 commits
59dce3d
b5dcede
94f0bb9
443dfa8
8a168e0
aacdc4c
8c012be
561c8d8
b96f05a
dc10530
72fe63c
8d9c4c1
a0c0262
623249c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which tidb version do you use? I tried it on my tidb cluster with tidb commit cac449b3370c5, and get different result.
and we can get 0 with this sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jyf111, thanks for sharing the version info. Currently, the "master" branch of TiDB docs is for TiDB v7.6.0. Would you please try installing TiDB v7.6 according to this quick start guide? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um.. But I don't know why
collation_connection
becomesutf8mb4_0900_ai_ci
.The latest doc still shows that the default value of
collation_connection
isutf8mb4_bin
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jyf111, thanks for checking the version.
According to @YangKeao (a TiDB developer),
utf8mb4_0900_ai_ci
was introduced in v7.4 to be compatible with MySQL 8.0 (pingcap/tidb#45650).Starting from v7.4.0, the default collation of
utf8mb4
on TiDB depends on the version of MySQL client, and @YangKeao will create a PR to clarify this issue in the doc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jyf111 FYI, here is the docPR created by @YangKeao: https://github.com/pingcap/docs/pull/16423/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. I have updated the sentences related to case sensitivity and collations. PTAL