Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data-service-get-started.md #16112

Merged
merged 10 commits into from
Jan 19, 2024
Merged

Update data-service-get-started.md #16112

merged 10 commits into from
Jan 19, 2024

Conversation

sgykfjsm
Copy link
Contributor

@sgykfjsm sgykfjsm commented Jan 11, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Fix #15743

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 11, 2024
@qiancai qiancai self-requested a review January 11, 2024 07:19
@qiancai qiancai added 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. translation/no-need No need to translate this PR. labels Jan 11, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 11, 2024
@qiancai qiancai added missing-translation-status This PR does not have translation status info. area/tidb-cloud This PR relates to the area of TiDB Cloud. labels Jan 11, 2024
@qiancai qiancai linked an issue Jan 11, 2024 that may be closed by this pull request
@qiancai qiancai self-assigned this Jan 11, 2024
@qiancai qiancai requested a review from heibaijian January 11, 2024 10:20
@qiancai qiancai removed the missing-translation-status This PR does not have translation status info. label Jan 11, 2024
Copy link

ti-chi-bot bot commented Jan 11, 2024

@heibaijian: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sgykfjsm, I've added some comments to this PR. PTAL. Thanks.

tidb-cloud/data-service-get-started.md Outdated Show resolved Hide resolved
tidb-cloud/data-service-get-started.md Outdated Show resolved Hide resolved
- To run all queries in the editor sequentially, press **Shift + Ctrl + Enter**, or select the lines of all queries with your cursor and click **Run**.

</div>
</SimpleTab>

Copy link
Collaborator

@qiancai qiancai Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Line 136~L160, please use the lines in https://github.com/pingcap/docs/blob/release-7.5/tidb-cloud/data-service-manage-endpoint.md?plain=1#L158-L182 instead as they are more accurate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed at 119633b

tidb-cloud/data-service-get-started.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 18, 2024
To run a SQL statement, select the line of the SQL with your cursor and click **Run** > **Run at cursor**.
<SimpleTab>
<div label="macOS">

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 19, 2024
Copy link

ti-chi-bot bot commented Jan 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-18 14:55:11.255020422 +0000 UTC m=+454152.819318123: ☑️ agreed by qiancai.
  • 2024-01-19 03:07:55.775566096 +0000 UTC m=+498117.339863785: ☑️ agreed by hfxsd.

@qiancai
Copy link
Collaborator

qiancai commented Jan 19, 2024

/approve

Copy link

ti-chi-bot bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit b6a6bf1 into pingcap:release-7.5 Jan 19, 2024
9 checks passed
@sgykfjsm sgykfjsm deleted the sgykfjsm-docdash2024 branch March 13, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.
Development

Successfully merging this pull request may close these issues.

Debug TiDB Cloud Documentation: Get Started with Data Service
4 participants