Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string-functions: add instructions for using CONCAT() and CONCAT_WS() #16048

Merged
merged 13 commits into from
Jan 30, 2024
Merged

string-functions: add instructions for using CONCAT() and CONCAT_WS() #16048

merged 13 commits into from
Jan 30, 2024

Conversation

Weaxs
Copy link
Contributor

@Weaxs Weaxs commented Jan 9, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Fix #15484

This PR adds instructions for the string functions CONCAT() and CONCAT_WS().

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

ti-chi-bot bot commented Jan 9, 2024

Welcome @Weaxs!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2024
@Weaxs
Copy link
Contributor Author

Weaxs commented Jan 9, 2024

/label 2024-tidb-docs-dash

@ti-chi-bot ti-chi-bot bot added the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Jan 9, 2024
@Weaxs
Copy link
Contributor Author

Weaxs commented Jan 9, 2024

/translation from-docs-cn

@ti-chi-bot ti-chi-bot bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Jan 9, 2024
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an example with a separator that's multiple characters.

sql> SELECT CONCAT_WS('-','Ti','DB');
+--------------------------+
| CONCAT_WS('-','Ti','DB') |
+--------------------------+
| Ti-DB                    |
+--------------------------+
1 row in set (0.0011 sec)

sql> SELECT CONCAT_WS('---','Ti','DB');
+----------------------------+
| CONCAT_WS('---','Ti','DB') |
+----------------------------+
| Ti---DB                    |
+----------------------------+
1 row in set (0.0011 sec)

functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
@dveeden dveeden requested a review from qiancai January 9, 2024 12:38
@dveeden
Copy link
Contributor

dveeden commented Jan 9, 2024

/verify

@rpaik
Copy link
Member

rpaik commented Jan 9, 2024

Thanks for participating in TiDB Docs Dash @Weaxs!

@dveeden
Copy link
Contributor

dveeden commented Jan 9, 2024

From the linter:

[2024-01-09T15:39:24.168Z] functions-and-operators/string-functions.md: this file has manual line breaks in the following lines:
[2024-01-09T15:39:24.168Z] 
[2024-01-09T15:39:24.168Z] MANUAL LINE BREAKS: L135
[2024-01-09T15:39:24.168Z] MANUAL LINE BREAKS: L146
[2024-01-09T15:39:24.168Z] MANUAL LINE BREAKS: L163
[2024-01-09T15:39:24.168Z] MANUAL LINE BREAKS: L195
[2024-01-09T15:39:24.168Z] MANUAL LINE BREAKS: L217
[2024-01-09T15:39:24.168Z] MANUAL LINE BREAKS: L441

@qiancai qiancai self-assigned this Jan 10, 2024
@qiancai
Copy link
Collaborator

qiancai commented Jan 26, 2024

Hi @Weaxs, I've submitted the commit 1491dc6 to align this PR with the Chinese doc changes in pingcap/docs-cn#16086. Would you please check if the commit is OK? Thanks.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 26, 2024
@qiancai
Copy link
Collaborator

qiancai commented Jan 26, 2024

/test pull-verify

@Weaxs
Copy link
Contributor Author

Weaxs commented Jan 26, 2024

Hi @Weaxs, I've submitted the commit 1491dc6 to align this PR with the Chinese doc changes in pingcap/docs-cn#16086. Would you please check if the commit is OK? Thanks.

I've checked the commit and it looks OK.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 30, 2024
Copy link

ti-chi-bot bot commented Jan 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-26 10:05:33.879272863 +0000 UTC m=+1127975.443570567: ☑️ agreed by dveeden.
  • 2024-01-30 03:53:24.103229742 +0000 UTC m=+1451245.667527432: ☑️ agreed by hfxsd.

@qiancai
Copy link
Collaborator

qiancai commented Jan 30, 2024

/retest

@qiancai
Copy link
Collaborator

qiancai commented Jan 30, 2024

/approve

Copy link

ti-chi-bot bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit cd9f590 into pingcap:master Jan 30, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Development

Successfully merging this pull request may close these issues.

Enrich instructions for string functions CONCAT() and CONCAT_WS()
6 participants