Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_control: add more info about sql ru consumption #16039

Merged
merged 9 commits into from
Jan 19, 2024
Merged

resource_control: add more info about sql ru consumption #16039

merged 9 commits into from
Jan 19, 2024

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Jan 9, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Jan 9, 2024
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2024
@hfxsd hfxsd requested review from songrijie, glorv and ran-huang January 9, 2024 03:57
@hfxsd hfxsd added v7.6 This PR/issue applies to TiDB v7.6. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Jan 9, 2024
glorv
glorv reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

songrijie
songrijie reviewed Jan 9, 2024
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
songrijie
songrijie approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@songrijie songrijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 9, 2024

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

rest LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jan 9, 2024
hfxsd
hfxsd commented Jan 10, 2024
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd commented Jan 10, 2024
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 11, 2024
ran-huang
ran-huang approved these changes Jan 11, 2024
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 11, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-11 04:57:59.293553614 +0000 UTC m=+505668.877807301: ☑️ agreed by ran-huang.

@hfxsd hfxsd added the lgtm label Jan 11, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 19, 2024

@glorv: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Jan 19, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 19, 2024
qiancai
qiancai reviewed Jan 19, 2024
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot merged commit fb6b1c7 into pingcap:master Jan 19, 2024
9 checks passed
PitifulPete pushed a commit to PitifulPete/tidb-docs that referenced this pull request Jan 19, 2024
@hfxsd @PitifulPete
resource_control: add more info about sql ru consumption (pingcap#16039)
65a4e32
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 6, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16456.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 6, 2024
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Feb 29, 2024
@ti-chi-bot
[DNM until v7.5.1] resource_control: add more info about sql ru consu…
172f3a6 
…mption (#16039) (#16456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai left review comments

@ran-huang ran-huang ran-huang approved these changes

@songrijie songrijie songrijie approved these changes

@glorv glorv glorv approved these changes

Assignees

@hfxsd hfxsd

Labels
approved contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.6 This PR/issue applies to TiDB v7.6.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hfxsd @ti-chi-bot @glorv @songrijie @ran-huang @qiancai @Oreoxmt