Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add description for --granularity #15977

Merged
merged 6 commits into from
Jan 22, 2024
Merged

br: add description for --granularity #15977

merged 6 commits into from
Jan 22, 2024

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Jan 5, 2024 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

pingcap/docs-cn#15944

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 5, 2024
@qiancai qiancai requested a review from Oreoxmt January 8, 2024 02:24
@qiancai qiancai added v7.6 This PR/issue applies to TiDB v7.6. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Jan 8, 2024
@Oreoxmt Oreoxmt self-assigned this Jan 8, 2024
Oreoxmt
Oreoxmt reviewed Jan 8, 2024
View reviewed changes
br/br-snapshot-guide.md Outdated Show resolved Hide resolved
br/br-snapshot-guide.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jan 8, 2024
View reviewed changes
br/br-snapshot-guide.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 8, 2024
@Oreoxmt Oreoxmt requested a review from qiancai January 8, 2024 09:46
Oreoxmt
Oreoxmt reviewed Jan 9, 2024
View reviewed changes
br/br-snapshot-guide.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Jan 11, 2024
View reviewed changes
br/br-snapshot-guide.md Outdated Show resolved Hide resolved
br/br-snapshot-guide.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt requested a review from qiancai January 11, 2024 02:57
@qiancai qiancai changed the title br: add new argument for snapshot restore br: add description for --granularity Jan 19, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 19, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-08 09:46:43.786251776 +0000 UTC m=+263793.370505447: ☑️ agreed by Oreoxmt.
  • 2024-01-19 03:45:25.869881723 +0000 UTC m=+500367.434179430: ☑️ agreed by qiancai.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jan 22, 2024

/verify

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jan 22, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit c69521d into master Jan 22, 2024
8 of 9 checks passed
@Oreoxmt Oreoxmt deleted the br_new_argument branch March 26, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.6 This PR/issue applies to TiDB v7.6.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3pointer @Oreoxmt @qiancai