Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bit reverse example to dev-guide-unique-serial-number-generation #15748

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Add bit reverse example to dev-guide-unique-serial-number-generation #15748

merged 3 commits into from
Dec 19, 2023

Conversation

Tetsuya3850
Copy link
Contributor

@Tetsuya3850 Tetsuya3850 commented Dec 17, 2023 •
edited by Oreoxmt
Loading

What is changed, added or deleted? (Required)

As discussed in this issue, it would be nice if we could clarify on what we mean by bit reverse. @Icemap have thankfully provided a sample to explain the same, so I just wanted to help in opening a PR to add it.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

#15263

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2023
@Tetsuya3850 Tetsuya3850 mentioned this pull request Dec 17, 2023
Closed
@Tetsuya3850
Copy link
Contributor Author

Oh, jenkins-docs/verify — Jenkins job failed.

I'm not sure of the rules,, if any guidance I may be able to fix it myself. But I can't quite find the ruleset.

@Oreoxmt Oreoxmt requested review from Icemap and Oreoxmt December 18, 2023 02:15
@Oreoxmt Oreoxmt added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. labels Dec 18, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Dec 18, 2023
@Oreoxmt Oreoxmt added the type/enhancement The issue or PR belongs to an enhancement. label Dec 18, 2023
@Tetsuya3850
Copy link
Contributor Author

@Oreoxmt Hi, thank you for the fix suggestion. Seems some verify is now successful but some others failed.. Sorry for the trouble..

@Oreoxmt
make jenkins happy
056c172 
Signed-off-by: Aolin <[email protected]>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 18, 2023

@Tetsuya3850 No worries, I have fixed the issue in 056c172. Thanks for your contribution!

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 18, 2023
Icemap
Icemap approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@Icemap Icemap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 18, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-18 07:03:33.443586197 +0000 UTC m=+858104.480813125: ☑️ agreed by Oreoxmt.
  • 2023-12-18 14:51:13.552322047 +0000 UTC m=+886164.589548969: ☑️ agreed by Icemap.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 19, 2023

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 19, 2023
@ti-chi-bot ti-chi-bot bot merged commit 7b6b947 into pingcap:master Dec 19, 2023
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15782.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 19, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15783.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 19, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #15784.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 19, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15785.

This was referenced Dec 19, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #15786.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 19, 2023
@ti-chi-bot
Add bit reverse example to dev-guide-unique-serial-number-generation (#…
d4b23c2 
…15748) (#15782)
ti-chi-bot bot pushed a commit that referenced this pull request Dec 19, 2023
@ti-chi-bot
Add bit reverse example to dev-guide-unique-serial-number-generation (#…
c47a538 
…15748) (#15786)
ti-chi-bot bot pushed a commit that referenced this pull request Dec 19, 2023
@ti-chi-bot
Add bit reverse example to dev-guide-unique-serial-number-generation (#…
85471a0 
…15748) (#15783)
ti-chi-bot bot pushed a commit that referenced this pull request Dec 19, 2023
@ti-chi-bot
Add bit reverse example to dev-guide-unique-serial-number-generation (#…
4381cf5 
…15748) (#15785)
ti-chi-bot bot pushed a commit that referenced this pull request Dec 19, 2023
@ti-chi-bot
Add bit reverse example to dev-guide-unique-serial-number-generation (#…
70d6ce2 
…15748) (#15784)
@llkdd1
Copy link
Contributor

llkdd1 commented Dec 25, 2023

/assign

@llkdd1 llkdd1 mentioned this pull request Jan 11, 2024
Merged
17 tasks
@Oreoxmt Oreoxmt added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jan 11, 2024
This was referenced Jan 24, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@Icemap Icemap Icemap approved these changes

Assignees

@llkdd1 llkdd1

Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. type/enhancement The issue or PR belongs to an enhancement.
Projects
2024 TiDB Docs Dash Issue List | 2024 TiDB 文档挑战赛任务列表
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tetsuya3850 @Oreoxmt @ti-chi-bot @llkdd1 @Icemap