Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb: fix config value for tiproxy #15635

Merged
merged 5 commits into from
Jan 16, 2024
Merged

tidb: fix config value for tiproxy #15635

merged 5 commits into from
Jan 16, 2024

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Dec 10, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

TiProxy is going to be released. This option is no more a pure warning.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@xhebox xhebox requested a review from qiancai December 10, 2023 17:31
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2023
@ran-huang ran-huang requested review from ran-huang and removed request for qiancai January 12, 2024 06:37
ran-huang
ran-huang reviewed Jan 15, 2024
View reviewed changes
@ran-huang ran-huang added translation/doing This PR's assignee is translating this PR. v7.6 This PR/issue applies to TiDB v7.6. labels Jan 15, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 15, 2024
@ran-huang ran-huang self-assigned this Jan 15, 2024
@ran-huang ran-huang added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jan 15, 2024
@ran-huang ran-huang mentioned this pull request Jan 15, 2024
Merged
18 tasks
@ran-huang ran-huang requested a review from hfxsd January 15, 2024 02:15
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jan 15, 2024
hfxsd
hfxsd reviewed Jan 15, 2024
View reviewed changes
hfxsd
hfxsd reviewed Jan 15, 2024
View reviewed changes
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 15, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 16, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-15 03:25:33.082805273 +0000 UTC m=+153574.647102964: ☑️ agreed by hfxsd.
  • 2024-01-16 08:11:20.496793772 +0000 UTC m=+257122.061091478: ☑️ agreed by ran-huang.

@ran-huang ran-huang added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2024
@ran-huang ran-huang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2024
@ti-chi-bot ti-chi-bot bot merged commit 67cbc2c into pingcap:master Jan 16, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 16, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #16174.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #16175.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 16, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16176.

This was referenced Jan 16, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #16177.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16178.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 16, 2024
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 17, 2024
@ti-chi-bot
tidb: fix config value for tiproxy (#15635) (#16178)
7793095
ti-chi-bot bot pushed a commit that referenced this pull request Jan 17, 2024
@ti-chi-bot
tidb: fix config value for tiproxy (#15635) (#16177)
4545a7b
ti-chi-bot bot pushed a commit that referenced this pull request Jan 17, 2024
@ti-chi-bot
tidb: fix config value for tiproxy (#15635) (#16176)
8b170dd
ti-chi-bot bot pushed a commit that referenced this pull request Jan 17, 2024
@ti-chi-bot
tidb: fix config value for tiproxy (#15635) (#16175)
cb508b4
ti-chi-bot bot pushed a commit that referenced this pull request Jan 17, 2024
@ti-chi-bot
tidb: fix config value for tiproxy (#15635) (#16174)
72f3c57
This was referenced Jan 17, 2024
Merged
Merged
Merged
Merged
Merged
PitifulPete pushed a commit to PitifulPete/tidb-docs that referenced this pull request Jan 19, 2024
@xhebox @PitifulPete
tidb: fix config value for tiproxy (pingcap#15635)
b7caa9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees

@ran-huang ran-huang

Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.6 This PR/issue applies to TiDB v7.6.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xhebox @ran-huang @ti-chi-bot @hfxsd