Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented resuming changefeed from Failed state #15555

Merged
merged 3 commits into from
Dec 25, 2023

Conversation

benmeadowcroft
Copy link
Collaborator

@benmeadowcroft benmeadowcroft commented Nov 30, 2023

What is changed, added or deleted? (Required)

From the Failed state the changefeed may be resumed (within the gc-ttl duration). For example, if a downstream issue is encountered for longer than 30 minutes the changefeed transitions to the Failure state. If that downstream issue is resolved within a few hours (less than the default 24 hour gc-ttl) the user may successfully resume the changefeed. This was not documented in the current overview.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2023
Copy link

ti-chi-bot bot commented Nov 30, 2023

@nongfushanquan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. and removed missing-translation-status This PR does not have translation status info. labels Dec 14, 2023
@qiancai qiancai self-requested a review December 14, 2023 07:50
@qiancai qiancai added the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Dec 14, 2023
@qiancai qiancai added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 19, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 22, 2023
Copy link

ti-chi-bot bot commented Dec 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-21 14:02:54.897756555 +0000 UTC m=+1142465.934983481: ☑️ agreed by qiancai.
  • 2023-12-22 05:26:56.47072811 +0000 UTC m=+1197907.507955038: ☑️ agreed by ran-huang.

@qiancai
Copy link
Collaborator

qiancai commented Dec 25, 2023

/approve

Copy link

ti-chi-bot bot commented Dec 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 25, 2023
@qiancai qiancai removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit 41cbbf1 into pingcap:release-7.1 Dec 25, 2023
8 of 9 checks passed
@qiancai qiancai self-assigned this Dec 26, 2023
@qiancai qiancai added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. labels Dec 26, 2023
@qiancai qiancai added the needs-cherry-pick-master Should cherry pick this PR to master branch. label Dec 26, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #15874.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15875.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch master: #15876.

@qiancai qiancai added the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Dec 27, 2023
@qiancai qiancai removed their assignment Dec 28, 2023
@enkilee
Copy link
Contributor

enkilee commented Dec 28, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved contribution This PR is from a community contributor. lgtm needs-cherry-pick-master Should cherry pick this PR to master branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository.
Development

Successfully merging this pull request may close these issues.

6 participants