Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statements: Add SHOW BINARY LOG STATUS info #15380

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 20, 2023

What is changed, added or deleted? (Required)

Add info about SHOW BINARY LOG STATUS being a new alias for SHOW MASTER STATUS.

Related to pingcap/tidb#48673

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 20, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 20, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 21, 2023
Copy link

ti-chi-bot bot commented Nov 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-20 12:12:06.635662365 +0000 UTC m=+233555.300888544: ☑️ agreed by lance6716.
  • 2023-11-21 06:18:02.290152962 +0000 UTC m=+298710.955379156: ☑️ agreed by ran-huang.

@ran-huang ran-huang added the translation/doing This PR's assignee is translating this PR. label Nov 21, 2023
@ran-huang ran-huang self-assigned this Nov 21, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 21, 2023
@ran-huang
Copy link
Contributor

/approve

Copy link

ti-chi-bot bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 21, 2023
@ran-huang
Copy link
Contributor

@dveeden Given the merge date of the pr (pingcap/tidb#48678), I assume the new alias is not included in v7.5, right?

@ran-huang ran-huang added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2023
@dveeden
Copy link
Contributor Author

dveeden commented Nov 21, 2023

@dveeden Given the merge date of the pr (pingcap/tidb#48678), I assume the new alias is not included in v7.5, right?

Yes correct. This is not in v7.5.

sql> SHOW MASTER STATUS;
+-------------+--------------------+--------------+------------------+-------------------+
| File        | Position           | Binlog_Do_DB | Binlog_Ignore_DB | Executed_Gtid_Set |
+-------------+--------------------+--------------+------------------+-------------------+
| tidb-binlog | 445788609072857088 |              |                  |                   |
+-------------+--------------------+--------------+------------------+-------------------+
1 row in set (0.0003 sec)

sql> SHOW BINARY LOG STATUS;
ERROR: 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 11 near "BINARY LOG STATUS" 

sql> SELECT TIDB_VERSION()\G
*************************** 1. row ***************************
TIDB_VERSION(): Release Version: v7.5.0-alpha-258-g603b47c991-dirty
Edition: Community
Git Commit Hash: 603b47c9917af415264f3de70359abadba2cd5bb
Git Branch: release-7.5
UTC Build Time: 2023-11-21 06:34:37
GoVersion: go1.21.0
Race Enabled: false
Check Table Before Drop: false
Store: unistore
1 row in set (0.0006 sec)

@ran-huang ran-huang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4ca0445 into pingcap:master Nov 21, 2023
6 checks passed
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants