Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the inaccuracies in the TLS description #15312

Merged
merged 9 commits into from
Nov 14, 2023

Conversation

lianan-352889950
Copy link

First-time contributors' checklist

What is changed, added or deleted? (Required)

Some descriptions were inaccurate and did not align with the current state of TiDB Cloud products. These inaccuracies caused inconvenience to users. To address this issue, adjustments have been made to ensure that the document aligns as closely as possible with the current status of TiDB Cloud products.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ qiancai
❌ lianan-352889950


lianan-352889950 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

ti-chi-bot bot commented Nov 9, 2023

Welcome @lianan-352889950!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2023
@qiancai qiancai self-requested a review November 9, 2023 07:23
@qiancai qiancai added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. labels Nov 13, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 13, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2023
@qiancai qiancai added the for-cloud-release This PR is related to TiDB Cloud release. label Nov 14, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 14, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2023
Copy link

ti-chi-bot bot commented Nov 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-14 01:59:11.880694236 +0000 UTC m=+4127949.467804382: ☑️ agreed by qiancai.
  • 2023-11-14 02:10:40.056571501 +0000 UTC m=+4128637.643681646: ☑️ agreed by hfxsd.

tidb-cloud/connect-via-standard-connection.md Outdated Show resolved Hide resolved
tidb-cloud/connect-via-standard-connection.md Outdated Show resolved Hide resolved
tidb-cloud/migrate-from-mysql-using-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/tidb-cloud-tls-connect-to-dedicated.md Outdated Show resolved Hide resolved
tidb-cloud/tidb-cloud-tls-connect-to-dedicated.md Outdated Show resolved Hide resolved
tidb-cloud/tidb-cloud-tls-connect-to-dedicated.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Nov 14, 2023

@Yuiham: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai
Copy link
Collaborator

qiancai commented Nov 14, 2023

/approve

Copy link

ti-chi-bot bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 14, 2023
@qiancai qiancai merged commit 77ea37d into pingcap:release-7.1 Nov 14, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. for-cloud-release This PR is related to TiDB Cloud release. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants