Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added event filter docs and consistency updates #15264

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Added event filter docs and consistency updates #15264

merged 5 commits into from
Nov 14, 2023

Conversation

benmeadowcroft
Copy link
Collaborator

@benmeadowcroft benmeadowcroft commented Nov 4, 2023 •
edited by hfxsd
Loading

What is changed, added or deleted? (Required)

Updated the changefeed documentation to include the new event filtering capability added to TiDB Cloud.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A
  • Other reference link(s): N/A

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 4, 2023

@grovecai: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. and removed missing-translation-status This PR does not have translation status info. contribution This PR is from a community contributor. labels Nov 6, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 6, 2023
@hfxsd hfxsd requested a review from qiancai November 6, 2023 06:47
@benmeadowcroft benmeadowcroft marked this pull request as ready for review November 6, 2023 19:24
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2023
qiancai
qiancai approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tidb-cloud/changefeed-overview.md Outdated Show resolved Hide resolved
tidb-cloud/changefeed-sink-to-apache-kafka.md Outdated Show resolved Hide resolved
tidb-cloud/changefeed-sink-to-mysql.md Outdated Show resolved Hide resolved
tidb-cloud/changefeed-sink-to-tidb-cloud.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-06 06:43:05.467442008 +0000 UTC m=+3453783.054552138: ☑️ agreed by hfxsd.
  • 2023-11-14 09:27:53.571076248 +0000 UTC m=+4154871.158186391: ☑️ agreed by qiancai.

@qiancai qiancai added the for-cloud-release This PR is related to TiDB Cloud release. label Nov 14, 2023
@hfxsd
Copy link
Collaborator

hfxsd commented Nov 14, 2023

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 14, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8e17c84 into pingcap:release-7.1 Nov 14, 2023
5 of 6 checks passed
@benmeadowcroft benmeadowcroft deleted the tidbcloud-changestream-event-filter branch November 30, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@hfxsd hfxsd hfxsd approved these changes

@grovecai grovecai grovecai approved these changes

Assignees
No one assigned
Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benmeadowcroft @hfxsd @grovecai @qiancai