Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a description in sql-plan-management.md #15087

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

The description was mistakenly deleted in https://github.com/pingcap/docs/pull/12279/files#diff-361475f3328cc7ffc8b281404195f6cefc2a7f86c9ea64542aa269a0ad10d459L181

The original Chinese version: pingcap/docs-cn@8e6c502#diff-361475f3328cc7ffc8b281404195f6cefc2a7f86c9ea64542aa269a0ad10d459

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang ran-huang added translation/no-need No need to translate this PR. ONCALL Relates to documentation oncall. labels Oct 16, 2023
@ran-huang ran-huang self-assigned this Oct 16, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2023
sql-plan-management.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-16 09:48:36.40581552 +0000 UTC m=+1650513.992925652: ☑️ agreed by qiancai.

@ran-huang
Copy link
Contributor Author

/approve

@ran-huang ran-huang added the lgtm label Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2181c6d into release-7.1 Oct 16, 2023
7 checks passed
@ran-huang ran-huang deleted the ran-huang-patch-4 branch October 20, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants