Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: refine changefeed scheduler configuration description #15050

Merged
merged 5 commits into from
Oct 17, 2023
Merged

ticdc: refine changefeed scheduler configuration description #15050

merged 5 commits into from
Oct 17, 2023

Conversation

ran-huang
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang ran-huang added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.2 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Oct 13, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2023
@ran-huang ran-huang requested a review from qiancai October 13, 2023 05:40
qiancai
qiancai approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-upstream-downstream-check.md Outdated Show resolved Hide resolved
ticdc/ticdc-upstream-downstream-check.md Outdated Show resolved Hide resolved
ticdc/ticdc-upstream-downstream-check.md Outdated Show resolved Hide resolved
ticdc/ticdc-upstream-downstream-check.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-16 06:32:42.72601006 +0000 UTC m=+1638760.313120203: ☑️ agreed by qiancai.

@ran-huang
Copy link
Contributor Author

/approve

@ran-huang ran-huang added the lgtm label Oct 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 17, 2023
@ti-chi-bot ti-chi-bot bot merged commit d3ba7ee into pingcap:master Oct 17, 2023
6 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 17, 2023
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #15109.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 17, 2023
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#15050
f5ebfee 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #15110.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 17, 2023
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#15050
e113527 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 17, 2023
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15111.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 17, 2023
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#15050
214d8c3 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 17, 2023
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15112.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 17, 2023
Merged
18 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 17, 2023
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#15050
f08f7ad 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15113.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 17, 2023
Merged
18 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 17, 2023
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#15050
b3f7665 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Oct 17, 2023
@ti-chi-bot
ticdc: refine changefeed scheduler configuration description (#15050) (…
26bb0c4 
…#15113)
ti-chi-bot bot pushed a commit that referenced this pull request Oct 17, 2023
@ti-chi-bot
ticdc: refine changefeed scheduler configuration description (#15050) (…
ee664a2 
…#15112)
ti-chi-bot bot pushed a commit that referenced this pull request Oct 17, 2023
@ti-chi-bot
ticdc: refine changefeed scheduler configuration description (#15050) (…
4062a73 
…#15111)
ti-chi-bot bot pushed a commit that referenced this pull request Oct 17, 2023
@ti-chi-bot
ticdc: refine changefeed scheduler configuration description (#15050) (…
dbf2522 
…#15109)
ti-chi-bot bot pushed a commit that referenced this pull request Oct 17, 2023
@ti-chi-bot
ticdc: refine changefeed scheduler configuration description (#15050) (…
900be14 
…#15110)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-huang @ti-chi-bot @qiancai