Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm and ticdc: removed links to lightning, and add table filter limitation to ticdc doc #15045

Merged
merged 8 commits into from
Oct 18, 2023
Merged

dm and ticdc: removed links to lightning, and add table filter limitation to ticdc doc #15045

merged 8 commits into from
Oct 18, 2023

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Oct 13, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

  • Removed links to TiDB Lightning in the DM doc
  • Added a limitation about table filter in the TiCDC doc
  • Add steps for GCS

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Oct 13, 2023
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2023
@hfxsd hfxsd added type/enhancement The issue or PR belongs to an enhancement. translation/no-need No need to translate this PR. area/dm area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. area/tidb-cloud This PR relates to the area of TiDB Cloud. and removed contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 13, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2023
@hfxsd hfxsd requested a review from qiancai October 17, 2023 07:20
qiancai
qiancai reviewed Oct 18, 2023
View reviewed changes
tidb-cloud/import-csv-files.md Outdated Show resolved Hide resolved
tidb-cloud/import-csv-files.md Outdated Show resolved Hide resolved
tidb-cloud/import-csv-files.md Outdated Show resolved Hide resolved
tidb-cloud/import-sample-data.md Outdated Show resolved Hide resolved
tidb-cloud/import-parquet-files.md Outdated Show resolved Hide resolved
tidb-cloud/import-sample-data.md Outdated Show resolved Hide resolved
tidb-cloud/migrate-from-mysql-using-data-migration.md Outdated Show resolved Hide resolved
tidb-cloud/migrate-from-mysql-using-data-migration.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Oct 18, 2023
View reviewed changes
tidb-cloud/import-csv-files.md Outdated Show resolved Hide resolved
tidb-cloud/import-parquet-files.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-18 08:08:31.497590935 +0000 UTC m=+1817309.084701065: ☑️ agreed by qiancai.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Oct 18, 2023

/verify

@hfxsd hfxsd closed this Oct 18, 2023
@hfxsd hfxsd reopened this Oct 18, 2023
@hfxsd hfxsd added the lgtm label Oct 18, 2023
@hfxsd
Copy link
Collaborator Author

hfxsd commented Oct 18, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit d59dbbf into pingcap:release-7.1 Oct 18, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frank945946 Frank945946 Frank945946 approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@hfxsd hfxsd

Labels
approved area/dm area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hfxsd @qiancai @Frank945946