Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Developer Guide - GUI - DBeaver #14927

Merged
merged 15 commits into from
Oct 23, 2023
Merged

feat: Developer Guide - GUI - DBeaver #14927

merged 15 commits into from
Oct 23, 2023

Conversation

Icemap
Copy link
Member

@Icemap Icemap commented Sep 26, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Icemap Icemap added translation/doing This PR's assignee is translating this PR. area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.2 labels Sep 26, 2023
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 26, 2023
@Oreoxmt Oreoxmt self-requested a review October 16, 2023 09:28
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 17, 2023

@Icemap Icemap#7 PTAL

Merge pull request #7 from Oreoxmt/update-feat-gui-dbeaver
2454417 
update TOC, wording, and screenshots
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 18, 2023
Oreoxmt
Oreoxmt reviewed Oct 18, 2023
View reviewed changes
develop/dev-guide-gui-dbeaver.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview: https://pingcap-docs-website-scaffold-git-preview-pingca-518ba9-oreoxmt.vercel.app/tidb/dev/dev-guide-gui-dbeaver

@qiancai
Copy link
Collaborator

qiancai commented Oct 20, 2023

Removed the needs-cherry-pick-release-7.2 label because the v7.2 docs have been archived at https://docs-archive.pingcap.com/tidb/v7.2 and will no longer receive new updates.

qiancai
qiancai approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-19 03:36:58.088481387 +0000 UTC m=+1887415.675591519: ☑️ agreed by Oreoxmt.
  • 2023-10-23 05:40:27.374279936 +0000 UTC m=+2240424.961390080: ☑️ agreed by qiancai.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 23, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 23, 2023
@ti-chi-bot ti-chi-bot bot merged commit 1acee2e into pingcap:master Oct 23, 2023
5 of 6 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15155.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 23, 2023
@ti-chi-bot
This is an automated cherry-pick of pingcap#14927
064aa04 
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Oct 23, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #15156.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 23, 2023
@ti-chi-bot
This is an automated cherry-pick of pingcap#14927
0720591 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15157.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 23, 2023
Merged
18 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 23, 2023
@ti-chi-bot
This is an automated cherry-pick of pingcap#14927
5283184 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #15158.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 23, 2023
Closed
18 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 23, 2023
@ti-chi-bot
This is an automated cherry-pick of pingcap#14927
817b3b0 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15159.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 23, 2023
Merged
18 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 23, 2023
@ti-chi-bot
This is an automated cherry-pick of pingcap#14927
9b33ce3 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Oct 23, 2023
@ti-chi-bot
feat: Developer Guide - GUI - DBeaver (#14927) (#15159)
59ddb23
ti-chi-bot bot pushed a commit that referenced this pull request Oct 23, 2023
@ti-chi-bot
feat: Developer Guide - GUI - DBeaver (#14927) (#15156)
675b707
ti-chi-bot bot pushed a commit that referenced this pull request Oct 25, 2023
@ti-chi-bot
feat: Developer Guide - GUI - DBeaver (#14927) (#15155)
5b7338c
ti-chi-bot bot pushed a commit that referenced this pull request Oct 25, 2023
@ti-chi-bot
feat: Developer Guide - GUI - DBeaver (#14927) (#15157)
3938436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@Icemap Icemap

Labels
approved area/develop This PR relates to the area of TiDB App development. lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Icemap @Oreoxmt @qiancai @ti-chi-bot @shizn