Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Developer Guide - GUI - VS Code SQLTools #14926

Merged
merged 11 commits into from
Nov 6, 2023
Merged

feat: Developer Guide - GUI - VS Code SQLTools #14926

merged 11 commits into from
Nov 6, 2023

Conversation

Icemap
Copy link
Member

@Icemap Icemap commented Sep 26, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Icemap Icemap added translation/doing This PR's assignee is translating this PR. area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.2 labels Sep 26, 2023
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 26, 2023
@Oreoxmt Oreoxmt self-requested a review October 16, 2023 09:28
@qiancai
Copy link
Collaborator

qiancai commented Oct 20, 2023

Removed the needs-cherry-pick-release-7.2 label because the v7.2 docs have been archived at https://docs-archive.pingcap.com/tidb/v7.2 and will no longer receive new updates.

Oreoxmt
Oreoxmt reviewed Oct 26, 2023
View reviewed changes
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Nov 3, 2023
View reviewed changes
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit to Oreoxmt/pingcap-docs-website-scaffold that referenced this pull request Nov 3, 2023
Preview PR pingcap/docs#14926 and this preview is triggered from commit
388f864 
pingcap/docs@e5fd5d1
Oreoxmt
Oreoxmt reviewed Nov 3, 2023
View reviewed changes
develop/dev-guide-gui-vscode-sqltools.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview: https://scaffold-git-preview-pingcapdocs14926-oreoxmt.vercel.app/tidb/dev/dev-guide-gui-vscode-sqltools

@Oreoxmt Oreoxmt requested a review from hfxsd November 3, 2023 08:08
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 6, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-06 02:20:59.846602061 +0000 UTC m=+3438057.433712206: ☑️ agreed by hfxsd.
  • 2023-11-06 02:37:34.065992187 +0000 UTC m=+3439051.653102503: ☑️ agreed by Oreoxmt.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 6, 2023

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 6, 2023
@ti-chi-bot ti-chi-bot bot merged commit 451d95c into pingcap:master Nov 6, 2023
5 of 6 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #15265.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 6, 2023
Closed
18 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 6, 2023
@ti-chi-bot
This is an automated cherry-pick of pingcap#14926
98aa52e 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15266.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 6, 2023
Merged
18 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 6, 2023
@ti-chi-bot
feat: Developer Guide - GUI - VS Code SQLTools (pingcap#14926)
67a6bde
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15267.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 6, 2023
Merged
18 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 6, 2023
@ti-chi-bot
feat: Developer Guide - GUI - VS Code SQLTools (pingcap#14926)
0fd9da5
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 6, 2023
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #15268.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 6, 2023
@ti-chi-bot
feat: Developer Guide - GUI - VS Code SQLTools (pingcap#14926)
d51b308
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15269.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 6, 2023
Merged
18 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 6, 2023
@ti-chi-bot
feat: Developer Guide - GUI - VS Code SQLTools (pingcap#14926)
512b786
@Oreoxmt Oreoxmt removed the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Nov 6, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Nov 6, 2023
@ti-chi-bot
feat: Developer Guide - GUI - VS Code SQLTools (#14926) (#15268)
bc2e1aa
ti-chi-bot bot pushed a commit that referenced this pull request Nov 6, 2023
@ti-chi-bot
feat: Developer Guide - GUI - VS Code SQLTools (#14926) (#15266)
3e68f76
ti-chi-bot bot pushed a commit that referenced this pull request Nov 6, 2023
@ti-chi-bot
feat: Developer Guide - GUI - VS Code SQLTools (#14926) (#15269)
85f0d36
ti-chi-bot bot pushed a commit that referenced this pull request Nov 6, 2023
@ti-chi-bot
feat: Developer Guide - GUI - VS Code SQLTools (#14926) (#15267)
97197ff
shiyuhang0 pushed a commit to shiyuhang0/docs that referenced this pull request Nov 6, 2023
@ti-chi-bot @shiyuhang0
feat: Developer Guide - GUI - VS Code SQLTools (pingcap#14926) (pingc…
3cc73fb 
…ap#15267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees
No one assigned
Labels
approved area/develop This PR relates to the area of TiDB App development. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Icemap @qiancai @Oreoxmt @ti-chi-bot @hfxsd @shizn