Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en: update the index title for better display #2645

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Nov 13, 2024

What is changed, added, or deleted? (Required)

Removes the word "Documentation" from the banner on https://docs.pingcap.com/tidb-in-kubernetes/stable, for better visual experience
image

and for consistency with that on https://docs.pingcap.com/tidb/stable , which doesn't use the word "Documentation"
image

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@lilin90 lilin90 added the translation/no-need The changes in this PR don't need to be translated. label Nov 13, 2024
@lilin90 lilin90 self-assigned this Nov 13, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 13, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 13, 2024
Copy link

ti-chi-bot bot commented Nov 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-13 07:27:01.50432372 +0000 UTC m=+427583.695192717: ☑️ agreed by Oreoxmt.

@lilin90 lilin90 added the lgtm label Nov 13, 2024
@lilin90
Copy link
Member Author

lilin90 commented Nov 13, 2024

/approve

Copy link

ti-chi-bot bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit 90805c1 into pingcap:master Nov 13, 2024
14 checks passed
@lilin90 lilin90 added needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. labels Nov 14, 2024
@lilin90 lilin90 deleted the update-banner-text branch November 14, 2024 01:58
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.3: #2646.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.4: #2647.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2648.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.6: #2649.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants