Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en, zh: del tidb-cluster and tidb-backup in v1.6.0 #2582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srstack
Copy link

@srstack srstack commented Jun 4, 2024

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jun 4, 2024
Copy link

ti-chi-bot bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ran-huang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 4, 2024
Copy link

ti-chi-bot bot commented Jun 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-04 06:12:52.814706391 +0000 UTC m=+3361726.571841965: ☑️ agreed by csuzhangxc.

@csuzhangxc csuzhangxc requested a review from Oreoxmt June 4, 2024 06:13
@Oreoxmt Oreoxmt added needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 4, 2024
@@ -200,8 +200,6 @@ helm search repo pingcap

```
NAME CHART VERSION APP VERSION DESCRIPTION
pingcap/tidb-backup v1.6.0 A Helm chart for TiDB Backup or Restore
pingcap/tidb-cluster v1.6.0 A Helm chart for TiDB Cluster
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srstack Could you please confirm whether lines 180-181 need to be removed?

* `tidb-cluster`: used to deploy TiDB clusters;
* `tidb-backup`: used to back up or restore TiDB clusters;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L180-L181 should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants