Skip to content

tikv: recorrect the settings of some configs and supplement missing annotations for several configs. #20261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 30, 2025

Conversation

LykxSassinator
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

As the title mentioned, this PR is used to recorrect the settings for some configurations in TiKV.

Meanwhile, for some newly introduced configurations, it supplements annotations for them.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

…nnotations for several configs.

Signed-off-by: lucasliang <[email protected]>
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 27, 2025
Copy link

ti-chi-bot bot commented Apr 27, 2025

Hi @LykxSassinator. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2025
@qiancai qiancai self-assigned this Apr 27, 2025
@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. and removed missing-translation-status This PR does not have translation status info. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 27, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 27, 2025
@qiancai
Copy link
Collaborator

qiancai commented Apr 27, 2025

/bot-review

Copy link

✅ AI review completed, 12 comments generated.

@pingcap pingcap deleted a comment from github-actions bot Apr 27, 2025
@pingcap pingcap deleted a comment from github-actions bot Apr 27, 2025
@pingcap pingcap deleted a comment from github-actions bot Apr 27, 2025
@pingcap pingcap deleted a comment from github-actions bot Apr 27, 2025
@pingcap pingcap deleted a comment from github-actions bot Apr 27, 2025
@pingcap pingcap deleted a comment from github-actions bot Apr 27, 2025
@pingcap pingcap deleted a comment from github-actions bot Apr 27, 2025
@pingcap pingcap deleted a comment from github-actions bot Apr 27, 2025
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LykxSassinator I've added some comments to this PR. PTAL, thanks. Btw, if the comments from the bot are inaccurate, you can edit them further before committing.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 27, 2025
Copy link

ti-chi-bot bot commented Apr 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-27 06:30:56.112716628 +0000 UTC m=+769199.924507004: ☑️ agreed by overvenus.
  • 2025-04-27 10:13:38.163276742 +0000 UTC m=+782561.975067123: ☑️ agreed by qiancai.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Grace Cai <[email protected]>
@qiancai qiancai added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Apr 30, 2025
@qiancai
Copy link
Collaborator

qiancai commented Apr 30, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 85792a5 into pingcap:master Apr 30, 2025
6 of 7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20300.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #20301.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20302.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #20303.
But this PR has conflicts, please resolve them!

ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. contribution This PR is from a community contributor. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ONCALL Relates to documentation oncall. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants