Skip to content

fix(pd): add missing configuration items for PD #20259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix(pd): add missing configuration items for PD #20259

wants to merge 7 commits into from

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Apr 27, 2025 •
edited by qiancai
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

Do your changes match any of the following descriptions?

  • Need modification after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 27, 2025
@qiancai qiancai self-assigned this Apr 27, 2025
@qiancai
Copy link
Collaborator

qiancai commented Apr 27, 2025

@JmPotato Please involve a tech reviewer for this PR. Thanks.

@qiancai qiancai added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. ONCALL Relates to documentation oncall. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Apr 27, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 28, 2025

@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai
Copy link
Collaborator

qiancai commented Apr 28, 2025

/bot-review

github-actions[bot]
github-actions bot reviewed Apr 28, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

✅ AI review completed, 6 comments generated.

@pingcap pingcap deleted a comment from github-actions bot Apr 28, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pingcap pingcap deleted a comment from github-actions bot Apr 28, 2025
@pingcap pingcap deleted a comment from github-actions bot Apr 28, 2025
qiancai
qiancai approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 28, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-28 07:19:18.116266217 +0000 UTC m=+858501.928056598: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2025
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2025
@JmPotato
Address the comments
d5d01d9 
Signed-off-by: JmPotato <[email protected]>
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@qiancai qiancai qiancai approved these changes

Assignees

@qiancai qiancai

Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JmPotato @qiancai @rleungx