Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emphasis the importance of input of unsafe recovery #18628

Merged
merged 9 commits into from
Dec 6, 2024
Merged

Emphasis the importance of input of unsafe recovery #18628

merged 9 commits into from
Dec 6, 2024

Conversation

v01dstar
Copy link
Contributor

@v01dstar v01dstar commented Sep 13, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@v01dstar
Add a note
bcde3bc 
Signed-off-by: Yang Zhang <[email protected]>
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 13, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2024

Hi @v01dstar. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2024
@v01dstar
Copy link
Contributor Author

/cc @overvenus

@ti-chi-bot ti-chi-bot bot requested a review from overvenus September 13, 2024 05:57
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 14, 2024
@qiancai qiancai removed the missing-translation-status This PR does not have translation status info. label Oct 24, 2024
@qiancai qiancai self-assigned this Oct 24, 2024
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Oct 24, 2024
@qiancai
Copy link
Collaborator

qiancai commented Oct 24, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 24, 2024
qiancai
qiancai reviewed Oct 24, 2024
View reviewed changes
online-unsafe-recovery.md Outdated Show resolved Hide resolved
@v01dstar
Address comments
3349959 
Signed-off-by: Yang Zhang <[email protected]>
qiancai
qiancai reviewed Nov 5, 2024
View reviewed changes
online-unsafe-recovery.md Outdated
@@ -56,6 +56,10 @@ pd-ctl -u <pd_addr> unsafe remove-failed-stores <store_id1,store_id2,...>

若 PD 进行过灾难性恢复 [`pd-recover`](/pd-recover.md) 操作，丢失了无法恢复的 TiKV 节点的 store 信息，因此无法确定要传的 store ID 时，可指定 `--auto-detect` 参数允许传入一个空的 store ID 列表。在该模式下，所有未在 PD store 列表中的 store ID 均被认为无法恢复，进行移除。

> **注意：**
>
> 请确保一次性输入 **所有** 失败的 TiKV 节点和 TiFlash 节点，如果有部分失败节点遗漏，恢复可能会被阻塞。如果在短时间内 (如一天时间内)，已经运行过一次 Online Unsafe Recovery ，请仍确保后续的执行仍然带有之前已经处理过的失败 TiKV 和 TiFlash 节点。如果无法确定所有的失败节点，可以使用 --auto-detect 模式，由 PD 将所有不在当前 store 列表中的副本删除。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“如果无法确定所有的失败节点，可以使用 --auto-detect 模式，由 PD 将所有不在当前 store 列表中的副本删除” 这里的内容看起来和 L57 有一定的重合呢，是否可以整合在一起

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

重新组织了一下，PTAL

qiancai
qiancai reviewed Nov 7, 2024
View reviewed changes
online-unsafe-recovery.md Outdated Show resolved Hide resolved
@v01dstar
Address comments
301f04f 
Signed-off-by: Yang Zhang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2024
@qiancai qiancai added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 3, 2024
qiancai
qiancai reviewed Dec 5, 2024
View reviewed changes
online-unsafe-recovery.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Dec 5, 2024
View reviewed changes
online-unsafe-recovery.md Outdated Show resolved Hide resolved
qiancai
qiancai approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-14 10:00:29.397446505 +0000 UTC m=+696099.137870444: ☑️ agreed by overvenus.
  • 2024-12-05 06:37:59.210973631 +0000 UTC m=+1309666.830628147: ☑️ agreed by qiancai.

qiancai
qiancai reviewed Dec 5, 2024
View reviewed changes
online-unsafe-recovery.md Outdated Show resolved Hide resolved
@qiancai qiancai mentioned this pull request Dec 5, 2024
Merged
16 tasks
qiancai
qiancai reviewed Dec 5, 2024
View reviewed changes
online-unsafe-recovery.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator

qiancai commented Dec 6, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 6, 2024
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 6, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 6, 2024
Merged
16 tasks
@ti-chi-bot ti-chi-bot bot merged commit 6638433 into pingcap:master Dec 6, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19225.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 6, 2024
Open
16 tasks
@v01dstar v01dstar deleted the unsafe-recovery branch December 6, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@overvenus overvenus overvenus approved these changes

Assignees

@qiancai qiancai

Labels
approved contribution This PR is from a community contributor. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v01dstar @qiancai @ti-chi-bot @overvenus