Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for ALTER SEQUENCE and sequence functions #17220

Merged
merged 9 commits into from
May 9, 2024
Merged

Add docs for ALTER SEQUENCE and sequence functions #17220

merged 9 commits into from
May 9, 2024

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Apr 26, 2024

What is changed, added or deleted? (Required)

Closes #16648

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.6 translation/from-docs This PR is translated from a PR in pingcap/docs. labels Apr 26, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2024
@qiancai qiancai self-assigned this Apr 29, 2024
@Oreoxmt Oreoxmt self-requested a review May 8, 2024 02:51
Oreoxmt
Oreoxmt reviewed May 8, 2024
View reviewed changes
sql-statements/sql-statement-create-sequence.md

{{< copyable "sql" >}}

```sql
SELECT nextval(seq);
SELECT NEXTVAL(seq);
```

```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L111:

    | NEXTVAL(seq) |

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in 12d2ef4

Oreoxmt
Oreoxmt approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 8, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-08 07:54:51.361552622 +0000 UTC m=+1035045.118688195: ☑️ agreed by Oreoxmt.

@qiancai
Copy link
Collaborator Author

qiancai commented May 9, 2024

/approve

@qiancai qiancai added the lgtm label May 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit 12a66b3 into pingcap:master May 9, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17294.

@ti-chi-bot ti-chi-bot mentioned this pull request May 9, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #17295.

@ti-chi-bot ti-chi-bot mentioned this pull request May 9, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17296.

@ti-chi-bot ti-chi-bot mentioned this pull request May 9, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request May 9, 2024
@ti-chi-bot
Add docs for ALTER SEQUENCE and sequence functions (#17220) (#17295)
842577a
ti-chi-bot bot pushed a commit that referenced this pull request May 9, 2024
@ti-chi-bot
Add docs for ALTER SEQUENCE and sequence functions (#17220) (#17294)
9271df5
ti-chi-bot bot pushed a commit that referenced this pull request May 9, 2024
@ti-chi-bot
Add docs for ALTER SEQUENCE and sequence functions (#17220) (#17296)
78dd93d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiancai @ti-chi-bot @Oreoxmt