Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for multi argument CHAR() #17011

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Apr 7, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Apr 7, 2024
@ti-chi-bot ti-chi-bot bot added the contribution This PR is from a community contributor. label Apr 7, 2024
@hfxsd hfxsd requested a review from dveeden April 7, 2024 09:14
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2024
@hfxsd hfxsd requested a review from qiancai April 7, 2024 09:14
@hfxsd hfxsd added needs-cherry-pick-release-8.0 translation/from-docs This PR is translated from a PR in pingcap/docs. and removed contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. labels Apr 7, 2024
Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not a good reviewer for docs-cn...

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2024
@hfxsd hfxsd requested review from Oreoxmt and removed request for qiancai April 8, 2024 11:17
@hfxsd hfxsd requested review from qiancai and removed request for Oreoxmt April 24, 2024 01:40
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 25, 2024
Copy link

ti-chi-bot bot commented Apr 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-25 03:53:05.060053323 +0000 UTC m=+232341.799956236: ☑️ agreed by qiancai.

@hfxsd hfxsd added the lgtm label Apr 26, 2024
@hfxsd
Copy link
Collaborator Author

hfxsd commented Apr 26, 2024

/approve
/approve

Copy link

ti-chi-bot bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit c573438 into pingcap:master Apr 26, 2024
6 of 7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17226.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants