Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function-and-operators: enrich instructions for string functions BIT_LENGTH() and CHAR() #15482 #16516

Merged

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Feb 5, 2024

What is changed, added or deleted? (Required)

  • Fix (Add a limitation for "Import into " SQL statement (#15480) #15482)
  • Describe the BIT_LENGTH() and CHAR() functions
  • Add three examples that illustrate how BIT_LENGTH() works and four examples that illustrate how CHAR() works.
  • Add a blockquote under the second BIT_LENGTH() example to indicate that the example operates under the assumption that a database exist
  • Add a blockquote before "Further Examples" to explain that CHAR() also works with non-ASCII character

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. area/develop This PR relates to the area of TiDB App development. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Feb 5, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2024
@qiancai qiancai removed the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Feb 5, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2024
@qiancai qiancai removed the area/develop This PR relates to the area of TiDB App development. label Feb 6, 2024
functions-and-operators/string-functions.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 6, 2024
Copy link

ti-chi-bot bot commented Feb 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-06 04:21:47.098853003 +0000 UTC m=+244232.665622892: ☑️ agreed by ran-huang.

@qiancai
Copy link
Collaborator Author

qiancai commented Feb 6, 2024

/retest

@qiancai
Copy link
Collaborator Author

qiancai commented Feb 6, 2024

/approve

@qiancai qiancai added the lgtm label Feb 6, 2024
Copy link

ti-chi-bot bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit ea62482 into pingcap:master Feb 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants