Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-functions: add info about special start_key/end_key values #16136

Conversation

RobertCheng-956
Copy link
Contributor

@RobertCheng-956 RobertCheng-956 commented Jan 11, 2024

What is changed, added or deleted? (Required)

translate-docs-pr#6728

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

add translation the document of tidb-functions.md from the pull request of pingcap#6728
tidb-functions: add info about special start_key/end_key values
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 11, 2024
@RobertCheng-956
Copy link
Contributor Author

/translation from-docs

@ti-chi-bot ti-chi-bot bot added translation/from-docs This PR is translated from a PR in pingcap/docs. and removed missing-translation-status This PR does not have translation status info. labels Jan 11, 2024
@rpaik rpaik added the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Jan 11, 2024
@lilin90 lilin90 self-requested a review January 11, 2024 06:50
@lilin90 lilin90 self-assigned this Jan 11, 2024
@lilin90 lilin90 added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jan 16, 2024
functions-and-operators/tidb-functions.md Outdated Show resolved Hide resolved
functions-and-operators/tidb-functions.md Outdated Show resolved Hide resolved
@lilin90
Copy link
Member

lilin90 commented Jan 19, 2024

@RobertCheng-956 Please update the content according to comments.

@RobertCheng-956
Copy link
Contributor Author

RobertCheng-956 commented Jan 19, 2024

@RobertCheng-956 Please update the content according to comments.

OK. There should be a space before and after inline cold wrapped by backticks?

@lilin90
Copy link
Member

lilin90 commented Jan 22, 2024

@RobertCheng-956 Please update the content according to comments.

OK. There should be a space before and after inline cold wrapped by backticks?

It's one rule in the PingCAP Style Guide. See 4.1.1 空白的使用 in https://github.com/pingcap/docs-cn/blob/master/resources/pingcap-style-guide-zh.pdf.
image

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 22, 2024
Copy link

ti-chi-bot bot commented Jan 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-22 03:45:54.946762387 +0000 UTC m=+759596.511060090: ☑️ agreed by lilin90.

@lilin90 lilin90 added the lgtm label Jan 22, 2024
@lilin90
Copy link
Member

lilin90 commented Jan 22, 2024

/approve

Copy link

ti-chi-bot bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit b39300f into pingcap:master Jan 22, 2024
6 of 7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16229.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16230.

@pushmeintheair
Copy link
Contributor

@RobertCheng-956 Please update the content according to comments.

OK. There should be a space before and after inline cold wrapped by backticks?

It's one rule in the PingCAP Style Guide. See 4.1.1 空白的使用 in https://github.com/pingcap/docs-cn/blob/master/resources/pingcap-style-guide-zh.pdf. image

Got it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Development

Successfully merging this pull request may close these issues.

5 participants