Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string-functions: update ASCII() and BIN() #16120

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

shawn0915
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Fix pingcap/docs#15418

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2024
@shawn0915
Copy link
Contributor Author

/label 2024-tidb-docs-dash

@ti-chi-bot ti-chi-bot bot added the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Jan 10, 2024
@rpaik rpaik requested a review from qiancai January 10, 2024 19:00
@qiancai qiancai self-assigned this Jan 11, 2024
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Jan 11, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 11, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 11, 2024
Copy link

ti-chi-bot bot commented Jan 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-11 10:13:42.811602213 +0000 UTC m=+524612.395855902: ☑️ agreed by qiancai.

@qiancai qiancai removed the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Jan 11, 2024
@qiancai
Copy link
Collaborator

qiancai commented Jan 11, 2024

Hi @shawn0915, thanks for fixing the issues.👍

I removed the Docs Dash label, but this will count towards your TiDB Docs Dash contribution for opening a new PR. https://github.com/orgs/pingcap/projects/51/views/11

Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 11, 2024

@xzhangxian1008: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai
Copy link
Collaborator

qiancai commented Jan 21, 2024

/approve

@qiancai qiancai added the lgtm label Jan 21, 2024
Copy link

ti-chi-bot bot commented Jan 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 21, 2024
@ti-chi-bot ti-chi-bot bot merged commit c5adb97 into pingcap:master Jan 21, 2024
7 checks passed
@shawn0915 shawn0915 deleted the br-shawnyan-15418 branch January 22, 2024 01:39
@qiancai qiancai added translation/no-need No need to translate this PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.
Development

Successfully merging this pull request may close these issues.

Enrich instructions for string functions ASCII() and BIN()
3 participants