Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] fix 15775 #16104

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Doc] fix 15775 #16104

wants to merge 3 commits into from
+18 −5

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jan 10, 2024 •
edited by qiancai
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

fix #15775

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ran-huang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2024
@rpaik rpaik added the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Jan 10, 2024
@qiancai qiancai requested a review from Icemap January 10, 2024 06:28
@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jan 10, 2024
Icemap
Icemap reviewed Jan 30, 2024
View reviewed changes
develop/dev-guide-sample-application-java-jdbc.md Outdated Show resolved Hide resolved
develop/dev-guide-sample-application-java-jdbc.md
@@ -161,6 +161,31 @@ cd tidb-java-jdbc-quickstart
make
```

若运行 `make` 时出现错误：
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以麻烦提供一下运行错误的环境吗？比如，OS、版本号等。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OS: Ubuntu
Version: 20,04.6 LTS
sh: ohmyzsh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我曾在 Ubuntu + dash，及 MacOS + zsh 上测试通过。是否是 oh-my-zsh 的配置问题？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看了下，主要是在Makefile文件这里。
all:
. env.sh
这里我用make执行时，报错

. env.sh && make build run
/bin/sh: 1: .: env.sh: not found
make: *** [Makefile:18: all] Error 2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把makefile的 . env.sh 换成 bash env.sh.
env.sh 的#!/bin/sh 换成 #!/bin/bash
就可以了。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像是make会默认强制用sh，但我记得ubuntu默认用的是bash吧。

develop/dev-guide-sample-application-java-jdbc.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icemap Icemap Icemap left review comments

Assignees

@Icemap Icemap

Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR.
Projects
2024 TiDB Docs Dash Issue List | 2024 TiDB 文档挑战赛任务列表
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug TiDB Documentation: 使用 JDBC 连接到 TiDB
4 participants
@enkilee @Icemap @rpaik @qiancai