This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
*: replace dumpling with tidb/dumpling #2263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Co-authored-by: lance6716 <[email protected]> Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
|
related to https://github.com/pingcap/dm/issues/2259 |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: ad92b60
|
|
@Little-Wallace: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/hold |
lichunzhu
reviewed
Oct 26, 2021
| @@ -540,7 +540,7 @@ All notable changes to this project will be documented in this file. | |||
| - Remove the restriction of "the next shard DDL statement cannot be executed unless the current shard DDL operation is completely finished in shard merge scene for binlog replication" [#177](https://github.com/pingcap/dm/pull/177) | |||
| - Support retry task on the `invalid connection` error for binlog replication [#66](https://github.com/pingcap/dm/pull/66) | |||
| - Support generating `-schema-create.sql` files automatically for full migration [#186](https://github.com/pingcap/dm/pull/186) | |||
| - Use [TiDB SQL Parser](https://github.com/pingcap/parser) to parse and restore DDL statements in binlog query events, and remove the `use db` statement when replicating to downstream [#54](https://github.com/pingcap/dm/pull/54) | |||
| - Use [TiDB SQL Parser](https://github.com/pingcap/tidb/parser) to parse and restore DDL statements in binlog query events, and remove the `use db` statement when replicating to downstream [#54](https://github.com/pingcap/dm/pull/54) | |||
There was a problem hiding this comment.
Suggested change
| - Use [TiDB SQL Parser](https://github.com/pingcap/tidb/parser) to parse and restore DDL statements in binlog query events, and remove the `use db` statement when replicating to downstream [#54](https://github.com/pingcap/dm/pull/54) | |
| - Use [TiDB SQL Parser](https://github.com/pingcap/tidb/tree/master/parser) to parse and restore DDL statements in binlog query events, and remove the `use db` statement when replicating to downstream [#54](https://github.com/pingcap/dm/pull/54) |
sleepymole
reviewed
Oct 26, 2021
| @@ -31,7 +31,7 @@ import ( | |||
|
|
|||
| const ( | |||
| // SingleRenameTableNameNum stands for number of TableNames in a single table renaming. it's 2 after | |||
| // https://github.com/pingcap/parser/pull/1021 | |||
| // https://github.com/pingcap/tidb/parser/pull/1021 | |||
There was a problem hiding this comment.
This line should be reverted.
|
ping @Little-Wallace , dumpling is merged into tidb now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
replace dumpling with tidb/dumpling. the repo
github.com/pingcap/dumplinghas been merged intogithub.com/pingcap/tidbclose https://github.com/pingcap/dm/issues/2259
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
dm/dm-ansible