Merge pull request #2 from pingcap-inc/feat/remove-package-download

feat: remove package download
pingcap-inc · May 14, 2024 · 7c20824 · 7c20824
2 parents 79373be + d04845b
commit 7c20824
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 7 deletions.
diff --git a/pingcap-jp/css/components/get-started.scss b/pingcap-jp/css/components/get-started.scss
@@ -56,4 +56,8 @@
 		display: block;
 		padding: 1rem 1.5rem;
 	}
+
+	&__footer-content{
+		margin-top: 3.2rem;
+	}
 }
diff --git a/pingcap-jp/css/scaffold/buttons.scss b/pingcap-jp/css/scaffold/buttons.scss
@@ -178,4 +178,14 @@ input[type="submit"],
 			justify-content: center;
 		}
 	}
+
+	.icon-github {
+		background: url("https://static.pingcap.com/files/2024/04/25211345/github.png") no-repeat
+			center/contain;
+		height: 2.4rem;
+		width: 2.4rem;
+		display: inline-block;
+		vertical-align: middle;
+		margin-right: 6px;
+	}
 }
diff --git a/pingcap-jp/grav-blocks/columns/block.php b/pingcap-jp/grav-blocks/columns/block.php
@@ -8,7 +8,7 @@
 
 $format = isset($format) && is_string($format) ? $format : ACF::get_sub_field_string('format');
 $columns = isset($columns) && is_array($columns) ? $columns : ACF::get_sub_field_array('columns');
-$column_num = isset($format) && is_string($column_num) ? $column_num : ACF::get_sub_field_string('column_num');
+$column_num = isset($column_num) && is_string($column_num) ? $column_num : ACF::get_sub_field_string('column_num');
 
 if ($columns) {
 	$block_inner_classes = [

diff --git a/pingcap-jp/inc/PingCAP/Components/GetStarted.php b/pingcap-jp/inc/PingCAP/Components/GetStarted.php
@@ -7,6 +7,7 @@
 
 class GetStarted implements IComponent
 {
+	public string $title = '';
 	public array $platforms = [];
 
 	public function __construct(array $params)
@@ -116,6 +117,9 @@ public function render(): void
 				}
 				?>
 			</div>
+			<div class="get-started__footer-content">
+				<a class="button" href="https://github.com/pingcap/tidb" data-gtag="event:product_download,tidb_download_version:view_on_github"><i class="icon-github"></i>View on GitHub</a>
+			</div>
 		</div>
 		<?php
 	}

diff --git a/pingcap-jp/templates/page-template-featured-content.php b/pingcap-jp/templates/page-template-featured-content.php
@@ -58,12 +58,12 @@
 									'platforms' => ACF::get_field_array('platforms'),
 									'title' => ACF::get_field_string('platform_title')
 								]);
-								Component::render(Components\PackageDownload::class, [
-									'version' => ACF::get_field_array('package_version'),
-									'packages' => ACF::get_field_array('package'),
-									'title' => ACF::get_field_string('package_download_title'),
-									'page_link' => ACF::get_field_array('package_download_page_link')
-								]);
+								// Component::render(Components\PackageDownload::class, [
+								// 	'version' => ACF::get_field_array('package_version'),
+								// 	'packages' => ACF::get_field_array('package'),
+								// 	'title' => ACF::get_field_string('package_download_title'),
+								// 	'page_link' => ACF::get_field_array('package_download_page_link')
+								// ]);
 
 								break;
 						}