Add lint, build, and test commands to justfile
, add fmt and clippy to CI workflow
#59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@haruska had some good feedback around adding explicit
build
,test
, andlint
commands to thejustfile
in the repo. Currently there are only commands for dealing with code generation which is a little confusing.Additionally, we haven't run
cargo fmt
andcargo clippy
on the codebase yet, and have nothing enforcing its use.Solution
justfile
: move all code generation undergen-*
commands, addbuild
,test
,lint
, andupdate
commands to the file.ci.yaml
workflow to support both fmt and clippy. Reject if running either leads to issues.Note: At the moment I've added
#![allow(clippy::enum_variant_names)]
and#![allow(clippy::empty_docs)]
to thesrc/openapi/mod.rs
file. There were some clippy issues in the generated code, and since we still need to refactor the entire generation flow in this repo, I just stuck the allow tags on top for now.Type of Change
Test Plan
Make sure CI passes.