Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameters from String to &str #43

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

ericapywang
Copy link
Contributor

@ericapywang ericapywang commented Jul 25, 2024

Problem

One of the parameters for fetch was &[String] instead of &[&str]. Similarly, one of the parameters for query_by_id was String instead of &str.

Solution

I changed the parameter types to &[&str] and &str respectively for consistency with other functions. I also updated all relevant code.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Test cases should pass.

@ericapywang ericapywang marked this pull request as ready for review July 25, 2024 19:46
@ericapywang ericapywang changed the title Change fetch parameters from &[String] to &[&str] Change parameters from String to &str Jul 25, 2024
@ericapywang ericapywang merged commit e90d293 into main Jul 25, 2024
1 check passed
@ericapywang ericapywang deleted the erica/fetch-params branch July 25, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants