Environment Variable Configuration #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssmith-pc
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Great work! Left some +1s on the feedback from @ssmith-pc, and also some considerations around tests.
emily-emily
force-pushed
the
emily/environment-variables
branch
from
8c399cb
to
656b849
Compare
ssmith-pc
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some parameters should be definable via environment variables, but this is not yet handled.
Solution
Added support for providing API key, controller host, and additional request headers through environment variables.
Type of Change
Test Plan
Test cases are written in
src/pinecone.rs.