Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate code based on a recent control plane change made to OAS #162

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

rohanshah18
Copy link
Contributor

@rohanshah18 rohanshah18 commented Oct 23, 2024

Problem

A change was made to the control plane OAS.

Solution

Regenerated code based on the latest OAS using the following commands:

git submodule init && git submodule update
./codegen/build-oas.sh 2024-10

Note: There are a lot of changes based on the updated timestamps only.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Existing integration tests should work.

@rohanshah18 rohanshah18 changed the title regenerate code based on a recent control plane change made to OAS Regenerate code based on a recent control plane change made to OAS Oct 23, 2024
@rohanshah18 rohanshah18 marked this pull request as ready for review October 23, 2024 21:04
Copy link
Contributor

@aulorbe aulorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rohanshah18 rohanshah18 merged commit 1fdcd9f into rshah/release-candidate/2024-10 Oct 23, 2024
7 checks passed
@rohanshah18 rohanshah18 deleted the rshah/generateCode branch October 23, 2024 22:43
rohanshah18 added a commit that referenced this pull request Oct 24, 2024
)

## Problem

A change was made to the control plane OAS.

## Solution

Regenerated code based on the latest OAS using the following commands:
```
git submodule init && git submodule update
./codegen/build-oas.sh 2024-10
```
Note: There are a lot of changes based on the updated timestamps only.

## Type of Change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Infrastructure change (CI configs, etc)
- [ ] Non-code change (docs, etc)
- [ ] None of the above: (explain here)

## Test Plan

Existing integration tests should work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants