Fix Windows path handling for cloud storage #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use posixpath.join instead of os.path.join to ensure consistent forward slashes for cloud storage paths across all platforms. This resolves the FileNotFoundError: b//o on Windows.
Replace os.path.join with posixpath.join in dataset_fsreader.py to ensure consistent forward slashes when accessing cloud storage on Windows.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use posixpath.join instead of os.path.join to ensure consistent forward slashes for cloud storage paths across all platforms. This resolves the FileNotFoundError: b//o on Windows.
Description
This PR fixes an issue with path handling on Windows platforms. The problem occurs because
os.path.join()uses backslashes (\) as path separators on Windows, but cloud storage systems like GCS require forward slashes (/).Changes Made
_join_cloud_pathto handle cloud storage path joining consistently across platformsposixpath.join()instead ofos.path.join()for all cloud storage path operationsTesting
Tested and confirmed working on Windows 11 Pro.
Issue
Fixes the
FileNotFoundError: b//oerror when using the library on Windows.