Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update link to point to splade-quora.ipynb #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justin-thurman
Copy link

@justin-thurman justin-thurman commented Jun 4, 2024

Problem

In the notebook splade-vector-generation.ipynb, there's a link to another notebook, splade-quora.ipynb. This link currently 404s.

Solution

This PR updates the link to point to the correct location of the splade-quora.ipynb notebook.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

I followed the updated link and verified that it points to the correct notebook.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant