-
Notifications
You must be signed in to change notification settings - Fork 127
Adding function calling to AnyscaleLLM #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kylehh All in all LGTM. Please see a few comments
If an LLM doesn't support function calling - it will raise NotImplementedError, which will be caught by FunctionCallingQueryGenerator
Instead of duplicating the full test suite, we've changed all OpenAI-like models to run parameterized in test_openai.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kylehh we've changed the format of test_openai.py
in a manner where it parameterizes all LLM classes that inherit from OpenAILLM
(like AnyscaleLLM
), and runs the same test cases for all of these classes.
This way - we don't need a dedicated test_anyscale.py
file which simply duplicates the entire test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've changed the testing scheme and made AnyscalseLLM
another parameterized case in test_openai.py
Problem
FunctionArrayProperty
Solution
Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.
Type of Change
Test Plan
Describe specific steps for validating this change.