Skip to content

Commit

Permalink
ParquetWorkload should be an ABC
Browse files Browse the repository at this point in the history
It does not implement the name() method hence should be marked as an
abstract base class.
  • Loading branch information
daverigby committed Apr 30, 2024
1 parent f419179 commit 6cdfcc6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion vsb/workloads/dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
class Dataset:
"""
Represents a Dataset used as the source of documents and/or queries for
Pinecone index operations.
Vector Search operations.
The set of datasets are taken from the Pinecone public datasets
(https://docs.pinecone.io/docs/using-public-datasets), which reside in a
Google Cloud Storage bucket and are downloaded on-demand on first access,
Expand Down
4 changes: 3 additions & 1 deletion vsb/workloads/parquet_workload/parquet_workload.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
from abc import ABC

from ..base import VectorWorkload
from ..dataset import Dataset
from ...databases.base import Index
from ...vsb_types import Record, SearchRequest


class ParquetWorkload(VectorWorkload):
class ParquetWorkload(VectorWorkload, ABC):
"""A static workload which is implemented by reading records and query from
two sets of parquet files.
The initial records for the workload are loaded from one set of parquet
Expand Down

0 comments on commit 6cdfcc6

Please sign in to comment.