Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of &dyn ClauseDatabase #78

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Dekker1
Copy link
Contributor

@Dekker1 Dekker1 commented Jan 17, 2025

To achieve this some of the (common) functionality previously contained
in the ClauseDatabase trait has been moved to a new
ClauseDabaseTools trait (named after Itertools). This allows us to
keep the same convenience methods.

To achieve this some of the (common) functionality previously contained
in the `ClauseDatabase` trait has been moved to a new
`ClauseDabaseTools` trait (named after Itertools). This allows us to
keep the same convenience methods.
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 67.58242% with 59 lines in your changes missing coverage. Please review.

Project coverage is 75.11%. Comparing base (4245595) to head (0507024).

Files with missing lines Patch % Lines
crates/pindakaas/src/lib.rs 79.01% 17 Missing ⚠️
crates/pindakaas/src/bool_linear.rs 62.06% 11 Missing ⚠️
crates/pindakaas/src/solver/splr.rs 0.00% 10 Missing ⚠️
crates/pindakaas/src/propositional_logic.rs 25.00% 4 Missing and 2 partials ⚠️
crates/pindakaas/src/integer.rs 77.27% 4 Missing and 1 partial ⚠️
crates/pindakaas/src/solver/libloading.rs 0.00% 4 Missing ⚠️
crates/pindakaas/src/solver/propagation.rs 33.33% 2 Missing ⚠️
crates/pindakaas/src/sorted.rs 50.00% 2 Missing ⚠️
crates/pindakaas/src/helpers.rs 0.00% 0 Missing and 1 partial ⚠️
crates/pindakaas/src/trace.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #78      +/-   ##
===========================================
+ Coverage    74.86%   75.11%   +0.25%     
===========================================
  Files           20       20              
  Lines         7196     7098      -98     
  Branches      7196     7098      -98     
===========================================
- Hits          5387     5332      -55     
+ Misses        1686     1642      -44     
- Partials       123      124       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant