-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unexisting name from plan data for Synchronizes a plan action #625
Open
andressspinetti
wants to merge
11
commits into
pinax:original
Choose a base branch
from
talpor:master
base: original
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
==========================================
+ Coverage 99.21% 99.21% +<.01%
==========================================
Files 33 33
Lines 1911 1913 +2
Branches 175 176 +1
==========================================
+ Hits 1896 1898 +2
Misses 7 7
Partials 8 8
Continue to review full report at Codecov.
|
andressspinetti
changed the title
Remove unexisting name from plan data for Synchronizes a plan action
WIP: Remove unexisting name from plan data for Synchronizes a plan action
Dec 20, 2018
andressspinetti
changed the title
WIP: Remove unexisting name from plan data for Synchronizes a plan action
Remove unexisting name from plan data for Synchronizes a plan action
Dec 20, 2018
…ync_plans" This reverts commit 00d8521.
paltman
added
the
Original
The original full pinax-stripe version with cached models and actions service layer
label
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Remove
name
from dict used for synchronize a plan.Any background context you want to provide?
Plan object does not come with name property and makes the plan signals to fail. More information in Stripe Docs: https://stripe.com/docs/api/plans#plan_object
What ticket or issue # does this fix?
Closes #[issue number]
Definition of Done (check if considered and/or addressed):