Drop deprecated force_text()
#327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, I can do this. I'll work on it as soon as I have access to a PC with good internet connection. Thanks. |
|
Splendid :) |
|
@jonathan-s Thank you for the input! |
mfonism
force-pushed
the
2020.03.27/improve-django3-support
branch
3 times, most recently
from
ffd02b1 to
35de838
Compare
mfonism
force-pushed
the
2020.03.27/improve-django3-support
branch
from
35de838 to
c9d3d3e
Compare
|
Done. |
|
@mfonism Thanks for doing this, it looks like there is a conflict with current master, so if you're able to rebase against current master that would be excellent! |
|
@jonathan-s I already rebased the branch against current master (and I've checked again that I did this). Plus, github isn't telling me there's a conflict... |
|
@mfonism I'm sorry! It must've been a glitch then. My bad. @KatherineMichel, this all good on my side, and I'd be happy to have this merged :) |
jonathan-s
previously approved these changes
Aug 13, 2020
KatherineMichel
previously approved these changes
Aug 19, 2020
KatherineMichel
approved these changes
Aug 19, 2020
|
I don't have access to it either so I'm unable to check.
…Sent from my mobile
On Thu, 20 Aug 2020, 01:15 KatherineMichel, ***@***.***> wrote:
@brosner <https://github.com/brosner> @paltman
<https://github.com/paltman> Any idea why status checks are stalling? I
don't think I have access to Pinax CircleCI to fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#327 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQGYEWJA42J4HX76Q2BLFTSBRMIXANCNFSM4LVBFSCQ>
.
|
|
Hello! Any change this being merged? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves Django 3 support in django-user-accounts.
It will drop private Python 2 compatibility APIs as well as features deprecated in Django 3.0It was inspired by (and will fix) #325, and was guided by the Django 3.0 release notes.It will drop the deprecated utility function
django.utils.encoding.force_text(), and replace it withdjango.utils.encoding.force_str()