Allow sync from singlefile #1064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
WhyNotHugo
reviewed
Apr 21, 2023
Comment on lines
-64
to
-72
| path = os.path.abspath(expand_path(path)) | ||
| try: | ||
| path_glob = path % "*" | ||
| except TypeError: | ||
| # If not exactly one '%s' is present, we cannot discover | ||
| # collections because we wouldn't know which name to assign. | ||
| raise NotImplementedError | ||
|
|
||
| placeholder_pos = path.index("%s") |
There was a problem hiding this comment.
See my comment here: #1056 (comment)
There was a problem hiding this comment.
I think removing this block is solves your initial intent, if I understand it right (will come back with more explanation in #1056 )
I can also confirm that the import from singlefile was now successful with current .patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1056
singlefileto always use the file stem (the filename without extension) as the name of the collection..vscodeand.envto.gitignore