Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Fix experimental test against 11.x-dev #84

Merged
merged 7 commits into from
Aug 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/codeception.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
include:
- { php-version: 8.1, database: "mariadb:10.3", dependencies: lowest, experimental: false }
- { php-version: 8.2, database: "mariadb:10.11", dependencies: highest, experimental: false }
- { php-version: 8.3, database: "mariadb:10.11", dependencies: highest, pimcore_version: "11.x-dev as 11.0.0", experimental: true }
- { php-version: 8.3, database: "mariadb:10.11", dependencies: highest, pimcore_version: "11.x-dev", experimental: true }

services:
redis:
Expand Down Expand Up @@ -99,6 +99,7 @@ jobs:
run: |
if [ ! -z "$PIMCORE_VERSION" ]; then
composer require --no-update pimcore/pimcore:"${PIMCORE_VERSION}"
composer require --no-update pimcore/admin-ui-classic-bundle:1.x-dev
fi

- name: "Install dependencies with Composer"
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
include:
- { php-version: "8.1", database: "mariadb:10.11", dependencies: "lowest", phpstan_args: "", experimental: false }
- { php-version: "8.2", database: "mariadb:10.11", dependencies: "highest", phpstan_args: "", experimental: false }
- { php-version: "8.3", database: "mariadb:10.11", dependencies: "highest", pimcore_version: "11.x-dev as 11.0.0", phpstan_args: "", experimental: true }
- { php-version: "8.3", database: "mariadb:10.11", dependencies: "highest", pimcore_version: "11.x-dev", phpstan_args: "", experimental: true }
steps:
- name: "Checkout code"
uses: "actions/checkout@v2"
Expand All @@ -48,6 +48,7 @@ jobs:
run: |
if [ ! -z "$PIMCORE_VERSION" ]; then
composer require --no-update pimcore/pimcore:"${PIMCORE_VERSION}"
composer require --no-update pimcore/admin-ui-classic-bundle:1.x-dev
kingjia90 marked this conversation as resolved.
Show resolved Hide resolved
fi

- name: "Install dependencies with Composer"
Expand Down
Loading