Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Fix experimental test against 11.x-dev #84

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

kingjia90
Copy link
Contributor

No description provided.

@kingjia90 kingjia90 added this to the 1.3.1 milestone Jul 25, 2024
@kingjia90 kingjia90 force-pushed the remove-experimental-test branch from 21b253a to 6f55b67 Compare July 25, 2024 09:57
@kingjia90 kingjia90 changed the title [Task]: Remove experimental 11.x-dev test [Task]: Fix experimental test against 11.x-dev Jul 25, 2024
@blankse
Copy link
Contributor

blankse commented Jul 25, 2024

pimcore/demo#578 (comment)

You could also add a branch alias for pimcore/pimcore, like pimcore/admin-ui-classic-bundle#594

Then you can remove the "as 11.0.0" and the test will know the right version.

@blankse
Copy link
Contributor

blankse commented Jul 25, 2024

@kingjia90 I created the PR for the branch alias: pimcore/pimcore#17403
When this is merged you could use 11.x-dev without as 11.0.0

@blankse
Copy link
Contributor

blankse commented Jul 25, 2024

Why are the admin-ui-classic-bundle versions 1.5.0 and 1.5.1 not allowed with Pimcore 11.4? (Requires ~11.3.0)

In this case, you also need the admin-ui-classic-bundle version 1.x to work. It requires ^11.3.0.

@brusch
Copy link
Member

brusch commented Jul 25, 2024

@kingjia90 why not just use

  "prefer-stable": true,
  "minimum-stability": "dev",

as we do in other bundles?
Should work, right?

See: https://github.com/pimcore/copilot-bundle/blob/1.x/composer.json#L15

@blankse
Copy link
Contributor

blankse commented Jul 25, 2024

@brusch I think this doesn't work with the requirements. The composer doesn't know exactly which version 11.x is. The admin-ui-classic-bundle requires ^11.3. At the moment, all tests will be updated to 11.3.99. However, I think it is easy to set one branch alias, so there is only one location to change it.

For example: pimcore/demo#578
But there were more changes to test workflows if I remember correctly

@kingjia90
Copy link
Contributor Author

iirc there was also a limitation due to the composer conflict not working well with the unreleased packages

@brusch
Copy link
Member

brusch commented Jul 25, 2024

But 11.x-dev should be covered by ^11.3 right?

@kingjia90
Copy link
Contributor Author

kingjia90 commented Jul 25, 2024

Mhh, i recall we had the stability dev and got removed at some point aa6d269 (#46) but i don't remember the reason anymore 😅 Let's see with #85 if it re-occurs and/or fixes the issue

@blankse
Copy link
Contributor

blankse commented Jul 25, 2024

But 11.x-dev should be covered by ^11.3 right?

I don't know. We always set branch aliases for .x branches. But when this is the case, why do you set an inline alias in all test workflows?

The current problem is that the admin-classic-ui-bundle has the requirement ~11.3.0 in the latest releases. This is also not covered. But the branch alias is now 11.4.x-dev. This is also not covered.

For conflicts, I think a more precise version is also needed.

@brusch
Copy link
Member

brusch commented Jul 26, 2024

@blankse agree - when using the tilde ~11.3.0 then 11.x-dev is not covered, but we have that for the admin-ui-classic-bundle. So I'm afraid we need the branch alias for that. @kingjia90 but for all the other bundles I'd keep the "minimum-stability": "dev", approach.

@kingjia90 kingjia90 merged commit 3bb74df into 1.3 Aug 7, 2024
8 checks passed
@kingjia90 kingjia90 deleted the remove-experimental-test branch August 7, 2024 16:15
@kingjia90 kingjia90 self-assigned this Aug 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants