-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: Fix experimental test against 11.x-dev #84
Conversation
21b253a
to
6f55b67
Compare
|
@kingjia90 I created the PR for the branch alias: pimcore/pimcore#17403 |
Why are the admin-ui-classic-bundle versions In this case, you also need the admin-ui-classic-bundle version |
@kingjia90 why not just use "prefer-stable": true,
"minimum-stability": "dev", as we do in other bundles? See: https://github.com/pimcore/copilot-bundle/blob/1.x/composer.json#L15 |
@brusch I think this doesn't work with the requirements. The composer doesn't know exactly which version 11.x is. The admin-ui-classic-bundle requires ^11.3. At the moment, all tests will be updated to 11.3.99. However, I think it is easy to set one branch alias, so there is only one location to change it. For example: pimcore/demo#578 |
iirc there was also a limitation due to the composer |
But |
I don't know. We always set branch aliases for .x branches. But when this is the case, why do you set an inline alias in all test workflows? The current problem is that the admin-classic-ui-bundle has the requirement ~11.3.0 in the latest releases. This is also not covered. But the branch alias is now 11.4.x-dev. This is also not covered. For conflicts, I think a more precise version is also needed. |
@blankse agree - when using the tilde |
No description provided.