[Fix] (re)Fix Field definition for field not found if field name is 'key' #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h upper case Resolves pimcore#369 Directly assign the key in the case where the "Direct" target strategy is used alongside with "SYSTEM Key". Currently, an error is thrown because `key` is not in `$this->fieldName` since it is a system field
SamyMP
changed the title
|
@SamyMP thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #369
Directly assign the key in the case where the "Direct" target strategy is used alongside with "SYSTEM Key".
Currently, an error is thrown because
keyis not in$this->getFieldDefinition()since it is a system field@dvesh3 related to your PR #377